convert to "rootless"

Dockerfile

@@ -1,32 +1,36 @@
 FROM ubuntu:noble
 
+ARG UID=1000
+ARG GID=1000
+
 ENV DEBIAN_FRONTEND=noninteractive
 
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
 # install prerequisites
-RUN apt update \
+RUN apt-get update \
-    && apt install -y --no-install-recommends \
+  && apt-get install -y --no-install-recommends \
-    curl ca-certificates \
+  curl \
-    jq \
+  ca-certificates \
-    libxml2-utils \
+  jq \
-    && apt autoremove \
+  libxml2-utils \
-    && apt clean \
+  sudo && \
-    && rm -rf /var/lib/apt/lists/*
+  apt-get autoremove && apt-get clean && \
+  rm -rf /var/lib/apt/lists/*
 
 # Remove default ubuntu user
-RUN userdel -r ubuntu \
+RUN userdel -r ubuntu && \
-    && useradd --create-home -u 1000 minecraft \
+  useradd --create-home -u 1000 minecraft && \
-    && mkdir -p /data \
+  echo 'minecraft ALL=(ALL) NOPASSWD: ALL' >> /etc/sudoers && \
-    && chown -R 1000:1000 /data
+  mkdir -p /data && \
+  chown -R ${UID}:${GID} /data
 
-USER minecraft
+RUN su -c "curl -sL https://github.com/Jabba-Team/jabba/raw/main/install.sh | bash && . ~/.jabba/jabba.sh" minecraft
-
-RUN curl -sL https://github.com/Jabba-Team/jabba/raw/main/install.sh | bash \
-    && . ~/.jabba/jabba.sh
-
-USER root
 
 COPY ./scripts/init /
 COPY ./scripts/mc /usr/local/bin 
 RUN chmod +x /init && chmod +x /usr/local/bin/mc
 
-CMD ["/init"]
+USER minecraft
+
+CMD ["/init"]

scripts/init

@@ -3,14 +3,16 @@
 PUID="${PUID:-1000}"
 PGID="${PGID:-1000}"
 
-setperms(){
+setperms() {
-    echo "Setting permissions to UID:${PUID} and GID:${PGID}"
+  echo "Setting permissions to UID:${PUID} and GID:${PGID}"
-    usermod -u ${PUID} minecraft > /dev/null 2>&1
+  sudo usermod -u ${PUID} minecraft >/dev/null 2>&1
-    groupmod -g ${PGID} minecraft > /dev/null 2>&1
+  sudo groupmod -g ${PGID} minecraft >/dev/null 2>&1
-    chown -R ${PUID}:${PGID} /data > /dev/null 2>&1
+  sudo chown -R ${PUID}:${PGID} /data >/dev/null 2>&1
-    sleep 2
+  echo "DONE"
+  sleep 2
 }
 
 setperms
 
-su -c "mc" minecraft
+mc
+

scripts/mc

@@ -1,154 +1,154 @@
 #!/bin/env bash
 
-MC_LOADER="${MC_LOADER:="paper"}"
+MC_LOADER="${MC_LOADER:-"paper"}"
-MC_VERSION=${MC_VERSION:="1.21.4"}
+MC_VERSION=${MC_VERSION:-"1.21.4"}
 
-JAVA_VERSION=${JAVA_VERSION:="temurin@21"}
+JAVA_VERSION=${JAVA_VERSION:-"temurin@21"}
-JAR=${JAR:="server.jar"}
+JAR=${JAR:-"server.jar"}
-MEM=${MEMORY:=2G}
+MEM=${MEMORY:-2G}
-ADD_ARGS=${ADD_ARGS:=""}
+ADD_ARGS=${ADD_ARGS:-""}
 
-RESTART=${RESTART:="true"}
+RESTART=${RESTART:-"true"}
 
 crash() {
-    sleep 5
+  sleep 5
-    exit 1
+  exit 1
 }
 
 setEula() {
-    if [[ ! -s "eula.txt" ]]; then
+  if [[ ! -s "eula.txt" ]]; then
-        echo "#By changing the setting below to TRUE you are indicating your agreement to our EULA (https://aka.ms/MinecraftEULA)." >eula.txt
+    echo "#By changing the setting below to TRUE you are indicating your agreement to our EULA (https://aka.ms/MinecraftEULA)." >eula.txt
-        echo "eula=true" >>eula.txt
+    echo "eula=true" >>eula.txt
-    fi
+  fi
 }
 
-javaCheck(){
+javaCheck() {
-    JAVA_HOME=/data/java/${JAVA_VERSION}
+  JAVA_HOME=/data/java/${JAVA_VERSION}
-    if [[ -f "$HOME/.jabba/jabba.sh" ]]; then
+  if [[ -f "$HOME/.jabba/jabba.sh" ]]; then
-        source $HOME/.jabba/jabba.sh
+    source $HOME/.jabba/jabba.sh
-    else
+  else
-        echo "Something went wrong with locating jabba(the java installer)"
+    echo "Something went wrong with locating jabba(the java installer)"
-        exit 0
+    exit 0
-    fi
+  fi
 
-    if [[ ! -n "${JAVA_VERSION}" ]]; then
+  if [[ ! -n "${JAVA_VERSION}" ]]; then
-        echo "NO JAVA_VERSION ENVIRONMENT VARIABLE SET SET IT"
+    echo "NO JAVA_VERSION ENVIRONMENT VARIABLE SET SET IT"
-        crash
+    crash
-    fi
+  fi
 
-    if [[ ! -f "/data/java/${JAVA_VERSION}/bin/java" ]]; then
+  if [[ ! -f "/data/java/${JAVA_VERSION}/bin/java" ]]; then
-        rm -rf /data/java/${JAVA_VERSION}
+    rm -rf /data/java/${JAVA_VERSION}
-        jabba install ${JAVA_VERSION} -o /data/java/${JAVA_VERSION}
+    jabba install ${JAVA_VERSION} -o /data/java/${JAVA_VERSION}
-    fi
+  fi
-    PATH=${JAVA_HOME}/bin:$PATH
+  PATH=${JAVA_HOME}/bin:$PATH
-    JAVA="java"
+  JAVA="java"
 }
 
 getPaper() {
-    LATEST_BUILD=$(curl -s https://api.papermc.io/v2/projects/${MC_LOADER}/versions/${MC_VERSION}/builds |
+  LATEST_BUILD=$(curl -s https://api.papermc.io/v2/projects/${MC_LOADER}/versions/${MC_VERSION}/builds |
-        jq -r '.builds | map(select(.channel == "default") | .build) | .[-1]')
+    jq -r '.builds | map(select(.channel == "default") | .build) | .[-1]')
 
-    if [ "$LATEST_BUILD" != "null" ]; then
+  if [ "$LATEST_BUILD" != "null" ]; then
-        JAR_NAME=${MC_LOADER}-${MC_VERSION}-${LATEST_BUILD}.jar
+    JAR_NAME=${MC_LOADER}-${MC_VERSION}-${LATEST_BUILD}.jar
-        PAPERMC_URL="https://api.papermc.io/v2/projects/${MC_LOADER}/versions/${MC_VERSION}/builds/${LATEST_BUILD}/downloads/${JAR_NAME}"
+    PAPERMC_URL="https://api.papermc.io/v2/projects/${MC_LOADER}/versions/${MC_VERSION}/builds/${LATEST_BUILD}/downloads/${JAR_NAME}"
 
-        # Download the latest Paper version
+    # Download the latest Paper version
-        curl -o server.jar $PAPERMC_URL
+    curl -o server.jar $PAPERMC_URL
-        echo "Download completed"
+    echo "Download completed"
-        echo "Minecraft Version: ${MC_VERSION}"
+    echo "Minecraft Version: ${MC_VERSION}"
-        echo "Paper Version: ${LATEST_BUILD}"
+    echo "Paper Version: ${LATEST_BUILD}"
+  else
+    echo "No stable build for version $MC_VERSION found :("
+  fi
+}
+
+getFabric() {
+  LATEST_BUILD=$(curl -s https://meta.fabricmc.net/v2/versions/loader/${MC_VERSION} | jq -s '.[] .[0] .loader .version' | tr -d '"')
+  LATEST_INSTALLER=$(curl -s https://maven.fabricmc.net/net/fabricmc/fabric-installer/maven-metadata.xml | xmllint --xpath "/metadata/versioning/latest/text()" -)
+  DL_URL=https://meta.fabricmc.net/v2/versions/loader/${MC_VERSION}/${LATEST_BUILD}/${LATEST_INSTALLER}/server/jar
+  if [ "$LATEST_BUILD" != "null" ]; then
+    echo "$DL_URL"
+    curl -o server.jar ${DL_URL}
+  else
+    echo "TODO ERROR TEXT"
+  fi
+
+}
+
+getForge() {
+  LATEST_BUILD=$(curl -s https://files.minecraftforge.net/net/minecraftforge/forge/promotions_slim.json | jq -r ".promos[\"${MC_VERSION}-latest\"]")
+  DL_BUILD=${MC_VERSION}-${LATEST_BUILD}
+  DL_URL=https://maven.minecraftforge.net/net/minecraftforge/forge/$DL_BUILD/forge-$DL_BUILD-installer.jar
+  if [ "$LATEST_BUILD" != "null" ]; then
+    echo "$DL_URL"
+    curl -o forge-install.jar ${DL_URL}
+    echo "$JAVA -jar forge-install.jar --installServer"
+    $JAVA -jar forge-install.jar --installServer
+    ln -s forge-${MC_VERSION}-${LATEST_BUILD}-shim.jar server.jar
+    touch server.properties
+
+    rm -f user_jvm_args.txt
+    rm -f forge-install.jar
+    rm -f forge-install.jar.log
+    rm -f README.txt
+    rm -f run.bat
+    rm -f run.sh
+  else
+    echo "TODO ERROR TEXT"
+  fi
+}
+
+serverSelect() {
+  mkdir -p /data/server
+  cd /data/server
+  if [[ ! -f server.jar ]]; then
+    case $MC_LOADER in
+    vanilla)
+      getVanilla
+      ;;
+    paper)
+      getPaper
+      ;;
+    fabric)
+      getFabric
+      ;;
+    forge)
+      getForge
+      ;;
+    *)
+      echo "Server of type ${MC_LOADER} is not recognized."
+      crash
+      ;;
+    esac
+  fi
+}
+
+buildCommand() {
+  JAVA_ARGS="-Xms${MEM} -Xmx${MEM}"
+  if [[ -z ${ADD_ARGS+x} ]]; then
+    RUN_STRING="${ADD_ARGS} ${JAVA_ARGS} -jar ${JAR} nogui"
+  else
+    RUN_STRING="${JAVA_ARGS} -jar ${JAR} nogui"
+  fi
+}
+
+runServer() {
+  setEula
+  while true; do
+    if [[ -f $JAR ]]; then
+      buildCommand
+      echo "${JAVA} ${RUN_STRING}"
+      $JAVA ${RUN_STRING}
     else
-        echo "No stable build for version $MC_VERSION found :("
+      echo "${JAR} not found."
     fi
-}
+    if [[ "${RESTART}" != "true" ]]; then
-
+      echo "Exiting..."
-getFabric(){
+      exit 0
-    LATEST_BUILD=$(curl -s https://meta.fabricmc.net/v2/versions/loader/${MC_VERSION} | jq -s '.[] .[0] .loader .version' | tr -d '"')
-    LATEST_INSTALLER=$(curl -s https://maven.fabricmc.net/net/fabricmc/fabric-installer/maven-metadata.xml | xmllint --xpath "/metadata/versioning/latest/text()" -)
-    DL_URL=https://meta.fabricmc.net/v2/versions/loader/${MC_VERSION}/${LATEST_BUILD}/${LATEST_INSTALLER}/server/jar
-    if [ "$LATEST_BUILD" != "null" ]; then
-        echo "$DL_URL"
-        curl -o server.jar ${DL_URL}
-    else
-        echo "TODO ERROR TEXT"
     fi
-
+    echo -e "\n${RD}Automatically restarting server in 5 seconds. Press CTRL + C to abort and exit.${NC}"
-}
+    sleep 5
-
+  done
-getForge(){
-    LATEST_BUILD=$(curl -s https://files.minecraftforge.net/net/minecraftforge/forge/promotions_slim.json | jq -r ".promos[\"${MC_VERSION}-latest\"]")
-    DL_BUILD=${MC_VERSION}-${LATEST_BUILD}
-    DL_URL=https://maven.minecraftforge.net/net/minecraftforge/forge/$DL_BUILD/forge-$DL_BUILD-installer.jar
-    if [ "$LATEST_BUILD" != "null" ]; then
-        echo "$DL_URL"
-        curl -o forge-install.jar ${DL_URL}
-        echo "$JAVA -jar forge-install.jar --installServer"
-        $JAVA -jar forge-install.jar --installServer
-        ln -s forge-${MC_VERSION}-${LATEST_BUILD}-shim.jar server.jar
-        touch server.properties
-
-        rm -f user_jvm_args.txt
-        rm -f forge-install.jar
-        rm -f forge-install.jar.log
-        rm -f README.txt
-        rm -f run.bat
-        rm -f run.sh
-    else
-        echo "TODO ERROR TEXT"
-    fi
-}
-
-serverSelect(){
-    mkdir -p /data/server
-    cd /data/server
-    if [[ ! -f server.jar ]]; then
-        case $MC_LOADER in
-        vanilla)
-            getVanilla
-            ;;
-        paper)
-            getPaper
-            ;;
-        fabric)
-            getFabric
-            ;;
-        forge)
-            getForge
-            ;;
-        *)
-            echo "Server of type ${MC_LOADER} is not recognized."
-            crash
-            ;;
-        esac
-    fi
-}
-
-buildCommand(){
-    JAVA_ARGS="-Xms${MEM} -Xmx${MEM}"
-    if [[ -z ${ADD_ARGS+x} ]]; then
-        RUN_STRING="${ADD_ARGS} ${JAVA_ARGS} -jar ${JAR} nogui"
-    else
-        RUN_STRING="${JAVA_ARGS} -jar ${JAR} nogui"
-    fi
-}
-
-runServer(){
-    setEula
-    while true; do
-        if [[ -f $JAR ]]; then
-            buildCommand
-            echo "${JAVA} ${RUN_STRING}"
-            $JAVA ${RUN_STRING} 
-        else
-            echo "${JAR} not found."
-        fi
-        if [[ "${RESTART}" != "true" ]]; then
-            echo "Exiting..."
-            exit 0
-        fi
-        echo -e "\n${RD}Automatically restarting server in 5 seconds. Press CTRL + C to abort and exit.${NC}"
-        sleep 5
-    done
 }
 
 # ------------------------------------------------------------------------------- #